• Stefy Lanza (nextime / spora )'s avatar
    say why generation stopped, instead of always "stop" (v0.4.83) · a2e3a0f6
    Stefy Lanza (nextime / spora ) authored
    Measured against the production pod: a reasoning model asked for 64 tokens
    spent all 64 inside its thought, returned NO content, and the response said
    finish_reason "stop".
    
        max_tokens=64    finish=stop  content=0 chars ''             reasoning=262
        max_tokens=1500  finish=stop  content=13 chars 'XMU-5635-FB' reasoning=448
    
    Two layers were each sure the other knew better. The proxy hardcoded
    finish_reason = "stop" and never read choices[0].finish_reason from the remote;
    OpenAIFormatter then hardcoded it again, so even a caller that worked the
    reason out had it overwritten on the way to the client. vLLM had been saying
    "length" all along.
    
    It matters because "length" is the one reason a client can act on. An answer
    cut off at the limit is half a sentence, and told it stopped normally the client
    has nothing to retry on and no sign anything is missing. On a reasoning model
    the thought is generated FIRST and spends the same budget, so a tight limit
    returns an EMPTY answer that claims to have finished of its own accord -- which
    is how this surfaced, as a retrieval test scoring zero for reasons that had
    nothing to do with what it was measuring.
    
    The remote's word is now carried through the per-call sink beside reasoning,
    tool_calls and logprobs (get_last_finish_reason, buffered and streamed), the
    formatter accepts the caller's reason and keeps "stop" only as the default, and
    a tool call still wins -- that describes the answer's shape, and a truncation
    after the call was formed must not relabel it. Fixed at all five response
    exits, not just the one it was found at: streamed chat (both terminal-chunk
    paths), buffered chat, and streamed and buffered /v1/completions.
    
    A local backend is never told a reason, so the budget decides: generation that
    used every token it was allowed was cut off, not finished. Drawn only when a
    limit was actually set and reached -- never from a token count alone, or every
    long completion would be mislabelled.
    
    Tests verified against the reverted files: assert None == 'length' for the
    backends, TypeError: unexpected keyword 'finish_reason' for the formatter.
    Co-Authored-By: 's avatarClaude Opus 5 <noreply@anthropic.com>
    Claude-Session: https://claude.ai/code/session_01S8LAP3ueNzQJtwzhgVbq66
    a2e3a0f6
Name
Last commit
Last update
..
conftest.py Loading commit data...
ocr_lane_stub_worker.py Loading commit data...
test_admin_auth.py Loading commit data...
test_admin_forward_auth.py Loading commit data...
test_admin_remote_ui.py Loading commit data...
test_admission_gate_derived.py Loading commit data...
test_admission_gate_warning.py Loading commit data...
test_adoption_matches_image_and_card.py Loading commit data...
test_audio_ml_backends.py Loading commit data...
test_audio_ml_endpoints.py Loading commit data...
test_autoupgrade.py Loading commit data...
test_autoupgrade_force_options.py Loading commit data...
test_autoupgrade_midnight_force.py Loading commit data...
test_autoupgrade_recovers_a_down_server.py Loading commit data...
test_autoupgrade_sees_training.py Loading commit data...
test_broker_config.py Loading commit data...
test_broker_dispatch.py Loading commit data...
test_broker_protocol.py Loading commit data...
test_broker_shutdown.py Loading commit data...
test_broker_streaming.py Loading commit data...
test_burst_placement.py Loading commit data...
test_character_studio_fetch.py Loading commit data...
test_chat_passthrough.py Loading commit data...
test_chunking.py Loading commit data...
test_cluster.py Loading commit data...
test_compose.py Loading commit data...
test_context_compaction.py Loading commit data...
test_control_plane_never_starves.py Loading commit data...
test_embed_long_input.py Loading commit data...
test_embedding_capability.py Loading commit data...
test_embedding_repo_file_detection.py Loading commit data...
test_field_report_fixes.py Loading commit data...
test_finish_reason_is_the_real_one.py Loading commit data...
test_forward_auth_peer_trust.py Loading commit data...
test_front_api_auth.py Loading commit data...
test_front_forward_pool_ceiling.py Loading commit data...
test_front_inflight_leak.py Loading commit data...
test_front_ocr_swap_gate.py Loading commit data...
test_image_has_c_compiler.py Loading commit data...
test_ledger_out_of_band.py Loading commit data...
test_live_hourly_counts_booting_pods.py Loading commit data...
test_longcat_avatar_layout.py Loading commit data...
test_longcat_bsa.py Loading commit data...
test_longcat_cancellable.py Loading commit data...
test_longcat_checkpoint_resolve.py Loading commit data...
test_longcat_component_quant.py Loading commit data...
test_longcat_config_ui.py Loading commit data...
test_longcat_external_training.py Loading commit data...
test_longcat_int8_load.py Loading commit data...
test_longcat_lora.py Loading commit data...
test_longcat_orchestration.py Loading commit data...
test_longcat_packaging.py Loading commit data...
test_longcat_placement.py Loading commit data...
test_longcat_progress.py Loading commit data...
test_longcat_prompt_cache.py Loading commit data...
test_longcat_quantize.py Loading commit data...
test_longcat_scale.py Loading commit data...
test_longcat_tasks.py Loading commit data...
test_longcat_variants.py Loading commit data...
test_longcat_vendored_source.py Loading commit data...
test_longcat_venv_env.py Loading commit data...
test_longcat_vram_estimate.py Loading commit data...
test_longcat_worker.py Loading commit data...
test_loop_watch.py Loading commit data...
test_loop_watch_stack_dump.py Loading commit data...
test_manual_multimodal_test_client.py Loading commit data...
test_model_scan_cache.py Loading commit data...
test_models_context_window.py Loading commit data...
test_no_blocking_calls_on_the_loop.py Loading commit data...
test_ocr_accent_repair.py Loading commit data...
test_ocr_accent_token_ids.py Loading commit data...
test_ocr_accent_visibility.py Loading commit data...
test_ocr_blank_page.py Loading commit data...
test_ocr_chandra.py Loading commit data...
test_ocr_confidence.py Loading commit data...
test_ocr_degraded_retry.py Loading commit data...
test_ocr_detector_venv.py Loading commit data...
test_ocr_dual_mode.py Loading commit data...
test_ocr_early_loop_abort.py Loading commit data...
test_ocr_fanout.py Loading commit data...
test_ocr_fleet_workers.py Loading commit data...
test_ocr_language.py Loading commit data...
test_ocr_lease_leak_on_cancel.py Loading commit data...
test_ocr_lease_off_the_loop.py Loading commit data...
test_ocr_max_pages.py Loading commit data...
test_ocr_max_tokens_floor.py Loading commit data...
test_ocr_olmocr.py Loading commit data...
test_ocr_page_image.py Loading commit data...
test_ocr_page_reads_off_the_default_pool.py Loading commit data...
test_ocr_pod_async_transport.py Loading commit data...
test_ocr_pod_env_round_trip.py Loading commit data...
test_ocr_pod_pipeline_gate.py Loading commit data...
test_ocr_pod_pipeline_policy.py Loading commit data...
test_ocr_pod_pool_width.py Loading commit data...
test_ocr_queue_full_is_429.py Loading commit data...
test_ocr_raster_pool.py Loading commit data...
test_ocr_request_budgets.py Loading commit data...
test_ocr_resident_budget.py Loading commit data...
test_ocr_resume_engines.py Loading commit data...
test_ocr_resume_shared.py Loading commit data...
test_ocr_served_model.py Loading commit data...
test_ocr_surya_confidence.py Loading commit data...
test_ocr_token_trace.py Loading commit data...
test_ocr_unreadable_and_dpi.py Loading commit data...
test_ocr_vram_share_and_fallback.py Loading commit data...
test_ocr_window_published.py Loading commit data...
test_ocr_worker_lanes.py Loading commit data...
test_olmocr_pod_tls.py Loading commit data...
test_oom_priority.py Loading commit data...
test_parallel_requests_dont_cross.py Loading commit data...
test_parser_is_chosen_per_model.py Loading commit data...
test_placement_declines.py Loading commit data...
test_pod_env_booleans.py Loading commit data...
test_pod_gpu_telemetry.py Loading commit data...
test_pod_http_fleet_pool.py Loading commit data...
test_pod_http_pool.py Loading commit data...
test_pod_log_drain.py Loading commit data...
test_pod_loopback_tls.py Loading commit data...
test_pod_pool_fleet_ceiling.py Loading commit data...
test_pod_seed_model_type.py Loading commit data...
test_pod_teach_on_unknown_model.py Loading commit data...
test_pod_token_adoption_race.py Loading commit data...
test_pool_growth_adopts.py Loading commit data...
test_proxy_context_window.py Loading commit data...
test_proxy_logprobs.py Loading commit data...
test_proxy_tool_calls_survive.py Loading commit data...
test_remote_execution.py Loading commit data...
test_remote_gateway_gate.py Loading commit data...
test_remote_pinned_never_loads_locally.py Loading commit data...
test_runpod_adaptive_pod_width.py Loading commit data...
test_runpod_adopt_survivors.py Loading commit data...
test_runpod_capacity_cache.py Loading commit data...
test_runpod_card_memo.py Loading commit data...
test_runpod_client_pod_ceiling.py Loading commit data...
test_runpod_client_scale.py Loading commit data...
test_runpod_fleet_status.py Loading commit data...
test_runpod_grow_reason.py Loading commit data...
test_runpod_inflight_reclaim.py Loading commit data...
test_runpod_memory_bars.py Loading commit data...
test_runpod_mixed_fleet.py Loading commit data...
test_runpod_multi_worker.py Loading commit data...
test_runpod_no_duplicate_pods.py Loading commit data...
test_runpod_nonblocking_lease.py Loading commit data...
test_runpod_ocr_remotization.py Loading commit data...
test_runpod_per_pod_token.py Loading commit data...
test_runpod_placement.py Loading commit data...
test_runpod_pod_extra_args.py Loading commit data...
test_runpod_rate_limit_backoff.py Loading commit data...
test_runpod_reaper_grace.py Loading commit data...
test_runpod_refusal_is_not_death.py Loading commit data...
test_runpod_regional_volumes.py Loading commit data...
test_runpod_registry_heartbeat.py Loading commit data...
test_runpod_release_and_boot_cancel.py Loading commit data...
test_runpod_request_gpu_choice.py Loading commit data...
test_runpod_rest_fallback.py Loading commit data...
test_runpod_restart_orphans.py Loading commit data...
test_runpod_restart_reclaim.py Loading commit data...
test_runpod_scale_down.py Loading commit data...
test_runpod_scale_out.py Loading commit data...
test_runpod_schedule_region_spend.py Loading commit data...
test_runpod_status_never_hangs.py Loading commit data...
test_runpod_transient_api.py Loading commit data...
test_runpod_warm_floor_parallel.py Loading commit data...
test_runpod_warm_floor_rerent.py Loading commit data...
test_runpod_warm_floor_respects_max_pods.py Loading commit data...
test_runpod_warmup.py Loading commit data...
test_serving_load.py Loading commit data...
test_shared_pool_adapter_identity.py Loading commit data...
test_status_channel.py Loading commit data...
test_stream_error_is_not_silence.py Loading commit data...
test_studio_composed_surfaces.py Loading commit data...
test_surya_item_cap.py Loading commit data...
test_surya_loop_reported.py Loading commit data...
test_surya_retry_budget.py Loading commit data...
test_surya_runpod_fixes.py Loading commit data...
test_surya_thread_boundary.py Loading commit data...
test_system_reload_endpoint.py Loading commit data...
test_task_budget_and_teardown.py Loading commit data...
test_teach_carries_the_engine.py Loading commit data...
test_text_lora_to_pod.py Loading commit data...
test_thinking_reaches_the_client.py Loading commit data...
test_thread_pool_sized_from_env.py Loading commit data...
test_thread_pool_sizing.py Loading commit data...
test_tool_call_arguments_on_the_wire.py Loading commit data...
test_township_api_key.py Loading commit data...
test_township_clip_geometry.py Loading commit data...
test_township_longcat.py Loading commit data...
test_township_page_js.py Loading commit data...
test_township_templates.py Loading commit data...
test_township_video_dataset.py Loading commit data...
test_upgrade_launcher.py Loading commit data...
test_video_as_b64_scope.py Loading commit data...
test_video_geometry.py Loading commit data...
test_vllm_one_engine_per_card.py Loading commit data...
test_vllm_qwen_tool_parser_choice.py Loading commit data...
test_vllm_served_names_sections.py Loading commit data...
test_vllm_share_self_tuning.py Loading commit data...
test_vllm_tool_calling.py Loading commit data...
test_vram_releasers.py Loading commit data...
test_weight_stores.py Loading commit data...
test_whisper_server_local_models.py Loading commit data...