Fix AJAX job actions error handling

- Correct AJAX request detection by checking X-Requested-With header only
- Prevent fetch from following redirects with redirect: 'manual'
- Add robust response handling for redirects and JSON responses
- Ensure AJAX requests return JSON instead of HTML redirects

templates/jobs.html

@@ -222,15 +222,24 @@
             headers: {
                 'X-Requested-With': 'XMLHttpRequest'
             },
-            body: formData
+            body: formData,
+            redirect: 'manual'  // Don't follow redirects
         })
-        .then(response => response.json())
-        .then(data => {
-            if (data.success) {
-                // Show success notification
+        .then(response => {
+            if (response.status >= 200 && response.status < 300) {
+                // Success status
+                return response.json().then(data => {
+                    if (data.success !== false) {
+                        showActionNotification(jobId, action, 'success');
+                    } else {
+                        showActionNotification(jobId, action, 'error');
+                    }
+                });
+            } else if (response.status >= 300 && response.status < 400) {
+                // Redirect - treat as success for our purposes
                 showActionNotification(jobId, action, 'success');
-                // Status will be updated by the polling mechanism
             } else {
+                // Error status
                 showActionNotification(jobId, action, 'error');
             }
         })

vidai/web.py

@@ -403,12 +403,12 @@ def delete_job(job_id):
 
     if queue_manager.delete_job(job_id, user['id']):
         # Check if this is an AJAX request
-        if request.headers.get('Content-Type') == 'application/x-www-form-urlencoded' and request.headers.get('X-Requested-With') == 'XMLHttpRequest':
+        if request.headers.get('X-Requested-With') == 'XMLHttpRequest':
             return {'success': True, 'message': 'Job deleted successfully!'}
         flash('Job deleted successfully!', 'success')
     else:
         # Check if this is an AJAX request
-        if request.headers.get('Content-Type') == 'application/x-www-form-urlencoded' and request.headers.get('X-Requested-With') == 'XMLHttpRequest':
+        if request.headers.get('X-Requested-With') == 'XMLHttpRequest':
             return {'success': False, 'message': 'Failed to delete job or access denied.'}, 400
         flash('Failed to delete job or access denied.', 'error')
 
@@ -424,12 +424,12 @@ def cancel_job(job_id):
 
     if queue_manager.cancel_job(job_id, user['id']):
         # Check if this is an AJAX request
-        if request.headers.get('Content-Type') == 'application/x-www-form-urlencoded' and request.headers.get('X-Requested-With') == 'XMLHttpRequest':
+        if request.headers.get('X-Requested-With') == 'XMLHttpRequest':
             return {'success': True, 'message': 'Job cancelled successfully!'}
         flash('Job cancelled successfully!', 'success')
     else:
         # Check if this is an AJAX request
-        if request.headers.get('Content-Type') == 'application/x-www-form-urlencoded' and request.headers.get('X-Requested-With') == 'XMLHttpRequest':
+        if request.headers.get('X-Requested-With') == 'XMLHttpRequest':
             return {'success': False, 'message': 'Failed to cancel job or access denied.'}, 400
         flash('Failed to cancel job or access denied.', 'error')
 
@@ -445,12 +445,12 @@ def restart_job(job_id):
 
     if queue_manager.restart_job(job_id, user['id']):
         # Check if this is an AJAX request
-        if request.headers.get('Content-Type') == 'application/x-www-form-urlencoded' and request.headers.get('X-Requested-With') == 'XMLHttpRequest':
+        if request.headers.get('X-Requested-With') == 'XMLHttpRequest':
             return {'success': True, 'message': 'Job restarted successfully!'}
         flash('Job restarted successfully!', 'success')
     else:
         # Check if this is an AJAX request
-        if request.headers.get('Content-Type') == 'application/x-www-form-urlencoded' and request.headers.get('X-Requested-With') == 'XMLHttpRequest':
+        if request.headers.get('X-Requested-With') == 'XMLHttpRequest':
             return {'success': False, 'message': 'Failed to restart job or access denied.'}, 400
         flash('Failed to restart job or access denied.', 'error')