Commit a6357e82 authored by samhed's avatar samhed

* Hide the fullscreen toggle button on Safari since alphanumerical

  keyboard input doesn't work in fullscreen.
* Force clipping mode in Internet Explorer while in fullscreen since
  scrollbars doesn't work in fullscreen.
parent 6e296bfa
...@@ -59,6 +59,9 @@ html { ...@@ -59,6 +59,9 @@ html {
#sendCtrlAltDelButton { #sendCtrlAltDelButton {
display: none; display: none;
} }
#fullscreenButton {
display: none;
}
#noVNC_xvp_buttons { #noVNC_xvp_buttons {
display: none; display: none;
} }
......
...@@ -38,6 +38,7 @@ var UI; ...@@ -38,6 +38,7 @@ var UI;
ctrlOn: false, ctrlOn: false,
altOn: false, altOn: false,
isTouchDevice: false, isTouchDevice: false,
rememberedClipSetting: null,
// Setup rfb object, load settings from browser storage, then call // Setup rfb object, load settings from browser storage, then call
// UI.init to setup the UI/menus // UI.init to setup the UI/menus
...@@ -131,13 +132,17 @@ var UI; ...@@ -131,13 +132,17 @@ var UI;
UI.setBarPosition(); UI.setBarPosition();
} ); } );
// Hide the button if fullscreen isn't supported var isSafari = (navigator.userAgent.indexOf('Safari') != -1 &&
if (!document.documentElement.requestFullscreen && navigator.userAgent.indexOf('Chrome') == -1);
!document.documentElement.mozRequestFullScreen &&
!document.documentElement.webkitRequestFullscreen && // Only show the button if fullscreen is properly supported
!document.body.msRequestFullscreen) { // * Safari doesn't support alphanumerical input while in fullscreen
$D('fullscreenButton').style.display = "none"; if (!isSafari &&
} else { (document.documentElement.requestFullscreen ||
document.documentElement.mozRequestFullScreen ||
document.documentElement.webkitRequestFullscreen ||
document.body.msRequestFullscreen)) {
$D('fullscreenButton').style.display = "inline";
Util.addEvent(window, 'fullscreenchange', UI.updateFullscreenButton); Util.addEvent(window, 'fullscreenchange', UI.updateFullscreenButton);
Util.addEvent(window, 'mozfullscreenchange', UI.updateFullscreenButton); Util.addEvent(window, 'mozfullscreenchange', UI.updateFullscreenButton);
Util.addEvent(window, 'webkitfullscreenchange', UI.updateFullscreenButton); Util.addEvent(window, 'webkitfullscreenchange', UI.updateFullscreenButton);
...@@ -231,10 +236,7 @@ var UI; ...@@ -231,10 +236,7 @@ var UI;
$D("noVNC_connect_button").onclick = UI.connect; $D("noVNC_connect_button").onclick = UI.connect;
$D("noVNC_resize").onchange = function () { $D("noVNC_resize").onchange = UI.enableDisableViewClip;
var connected = UI.rfb && UI.rfb_state === 'normal';
UI.enableDisableViewClip(connected);
};
}, },
onresize: function (callback) { onresize: function (callback) {
...@@ -456,7 +458,7 @@ var UI; ...@@ -456,7 +458,7 @@ var UI;
if (document.fullscreenElement || // alternative standard method if (document.fullscreenElement || // alternative standard method
document.mozFullScreenElement || // currently working methods document.mozFullScreenElement || // currently working methods
document.webkitFullscreenElement || document.webkitFullscreenElement ||
document.msFullscreenElement ) { document.msFullscreenElement) {
if (document.exitFullscreen) { if (document.exitFullscreen) {
document.exitFullscreen(); document.exitFullscreen();
} else if (document.mozCancelFullScreen) { } else if (document.mozCancelFullScreen) {
...@@ -477,6 +479,7 @@ var UI; ...@@ -477,6 +479,7 @@ var UI;
document.body.msRequestFullscreen(); document.body.msRequestFullscreen();
} }
} }
UI.enableDisableViewClip();
UI.updateFullscreenButton(); UI.updateFullscreenButton();
}, },
...@@ -718,7 +721,7 @@ var UI; ...@@ -718,7 +721,7 @@ var UI;
$D('noVNC_cursor').disabled = true; $D('noVNC_cursor').disabled = true;
} }
UI.enableDisableViewClip(connected); UI.enableDisableViewClip();
$D('noVNC_resize').disabled = connected; $D('noVNC_resize').disabled = connected;
$D('noVNC_shared').disabled = connected; $D('noVNC_shared').disabled = connected;
$D('noVNC_view_only').disabled = connected; $D('noVNC_view_only').disabled = connected;
...@@ -875,6 +878,7 @@ var UI; ...@@ -875,6 +878,7 @@ var UI;
if (UI.rfb) { if (UI.rfb) {
display = UI.rfb.get_display(); display = UI.rfb.get_display();
} else { } else {
UI.forceSetting('clip', clip);
return; return;
} }
...@@ -921,15 +925,30 @@ var UI; ...@@ -921,15 +925,30 @@ var UI;
}, },
// Handle special cases where clipping is forced on/off or locked // Handle special cases where clipping is forced on/off or locked
enableDisableViewClip: function (connected) { enableDisableViewClip: function () {
var resizeElem = $D('noVNC_resize'); var resizeElem = $D('noVNC_resize');
var connected = UI.rfb && UI.rfb_state === 'normal';
if (resizeElem.value === 'downscale' || resizeElem.value === 'scale') { if (resizeElem.value === 'downscale' || resizeElem.value === 'scale') {
UI.forceSetting('clip', false); // Disable clipping if we are scaling
UI.setViewClip(false);
$D('noVNC_clip').disabled = true;
} else if (document.msFullscreenElement) {
// The browser is IE and we are in fullscreen mode.
// - We need to force clipping while in fullscreen since
// scrollbars doesn't work.
UI.togglePopupStatus("Forcing clipping mode since scrollbars aren't supported by IE in fullscreen");
UI.rememberedClipSetting = UI.getSetting('clip');
UI.setViewClip(true);
$D('noVNC_clip').disabled = true; $D('noVNC_clip').disabled = true;
} else if (document.body.msRequestFullscreen && UI.rememberedClip !== null) {
// Restore view clip to what it was before fullscreen on IE
UI.setViewClip(UI.rememberedClipSetting);
$D('noVNC_clip').disabled = connected || UI.isTouchDevice;
} else { } else {
$D('noVNC_clip').disabled = connected || UI.isTouchDevice; $D('noVNC_clip').disabled = connected || UI.isTouchDevice;
if (UI.isTouchDevice) { if (UI.isTouchDevice) {
UI.forceSetting('clip', true); UI.setViewClip(true);
} }
} }
}, },
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment