x11vnc: Add "sendbell" remote cmd. Fix copyrect updates under

-reflect.  Workaround that checks valid window of selection
requestor.  Wait on some ssl helper pids earlier.  Workaround
XAUTHLOCALHOSTNAME for some new usage modes.  Set fake fb to
requested bpp with correct masks.  -padgeom once:... mode.
Set LIBXCB_ALLOW_SLOPPY_LOCK by default. rfbRandomBytes earlier.
classes/ssl: Update jars.  Add "TOP_" dropdown customization to
ultravnc java viewer applet FTP panel.

classes/ssl/README

@@ -243,6 +243,16 @@ UltraVNC Java viewer only:
 
 		Home.Desktop.bin_2F_linux
 
+	If an item is prefixed with "TOP_" then the item is inserted at
+	the top of the drop down rather than being appended to the end.
+	E.g. to try to initially load the user homedir instead of /:
+
+		TOP_Home.My+Documents.Desktop
+
+	If ftpDropDown is set to the empty string, "", then no special
+	locations, [Desktop] etc., are placed in the drop down.  Only the
+	ultravnc "drives" will appear.
+
   ftpOnly
 	yes/no, default: no
 	The VNC viewer only shows the filetransfer panel, no desktop

x11vnc/ChangeLog

+2009-02-03  Karl Runge <runge@karlrunge.com>
+	* x11vnc: Add "sendbell" remote cmd.  Fix copyrect updates under
+	  -reflect.  Workaround that checks valid window of selection
+	  requestor.  Wait on some ssl helper pids earlier.  Workaround
+	  XAUTHLOCALHOSTNAME for some new usage modes.  Set fake fb to
+	  requested bpp with correct masks.  -padgeom once:... mode.
+	  Set LIBXCB_ALLOW_SLOPPY_LOCK by default. rfbRandomBytes earlier.
+	* classes/ssl: Update jars.  Add "TOP_" dropdown customization to
+	  ultravnc java viewer applet FTP panel.
+
 2009-01-11  Karl Runge <runge@karlrunge.com>
 	* classes/ssl: Add configurable Ultra java applet Filexfer Drives
 	  drop down (e.g. ftpDropDown=Home.Desktop.bin).  Document all  

x11vnc/help.c

@@ -52,7 +52,7 @@ void print_help(int mode) {
 "Also, use of a VNC password (-rfbauth or -passwdfile) is strongly recommended.\n"
 "\n"
 "For additional info see: http://www.karlrunge.com/x11vnc/\n"
-"                    and  http://www.karlrunge.com/x11vnc/#faq\n"
+"                    and  http://www.karlrunge.com/x11vnc/faq.html\n"
 "\n"
 "\n"
 "Config file support: if the file $HOME/.x11vncrc exists then each line in\n"
@@ -1343,10 +1343,11 @@ void print_help(int mode) {
 "                       The VNC Viewer-side needs to support SSL/TLS as well.\n"
 "                       See this URL and also the discussion below for\n"
 "                       ideas on how to enable SSL support for the viewer:\n"
-"                       http://www.karlrunge.com/x11vnc/#faq-ssl-tunnel-viewers\n"
-"                       x11vnc provides an SSL enabled Java viewer applet in\n"
-"                       the classes/ssl directory (-http or -httpdir options.)\n"
-"                       The SSVNC viewer package supports SSL tunnels too.\n"
+"                       http://www.karlrunge.com/x11vnc/faq.html#faq-ssl-tun\n"
+"                       nel-viewers x11vnc provides an SSL enabled Java\n"
+"                       viewer applet in the classes/ssl directory (-http or\n"
+"                       -httpdir options.)  The SSVNC viewer package supports\n"
+"                       SSL tunnels too.\n"
 "\n"
 "                       If the VNC Viewer supports VeNCrypt or ANONTLS (vino's\n"
 "                       encryption mode) they are also supported by the -ssl\n"
@@ -2460,6 +2461,10 @@ void print_help(int mode) {
 "                       to handle all subsequent resizes (e.g. under -xrandr,\n"
 "                       -remote id:windowid, rescaling, etc.)\n"
 "\n"
+"                       In -unixpw mode this sets the size of the login screen.\n"
+"                       Use \"once:WxH\" it ignore padgeom after the login\n"
+"                       screen is set up.\n"
+"\n"
 "-o logfile             Write stderr messages to file \"logfile\" instead of to\n"
 "                       the terminal.  Same as \"-logfile file\".  To append\n"
 "                       to the file use \"-oa file\" or \"-logappend file\".\n"
@@ -4382,6 +4387,7 @@ void print_help(int mode) {
 "                       fb              disable -nofb mode.\n"
 "                       bell            enable  bell (if supported).\n"
 "                       nobell          disable bell.\n"
+"                       sendbell        ring the bell now.\n"
 "                       nosel           enable  -nosel mode.\n"
 "                       sel             disable -nosel mode.\n"
 "                       noprimary       enable  -noprimary mode.\n"
@@ -4914,7 +4920,7 @@ void xopen_display_fail_message(char *disp) {
 	fprintf(stderr, "   change and the directory the cookie file resides in"
 	    " is system dependent.\n");
 	fprintf(stderr, "\n");
-	fprintf(stderr, "See also: http://www.karlrunge.com/x11vnc/#faq\n");
+	fprintf(stderr, "See also: http://www.karlrunge.com/x11vnc/faq.html\n");
 }
 
 void nopassword_warning_msg(int gotloc) {
@@ -4974,7 +4980,7 @@ void nopassword_warning_msg(int gotloc) {
 "#@  Please Read the documention for more info about          @#\n"
 "#@  passwords, security, and encryption.                     @#\n"
 "#@                                                           @#\n"
-"#@    http://www.karlrunge.com/x11vnc/#faq-passwd            @#\n"
+"#@    http://www.karlrunge.com/x11vnc/faq.html#faq-passwd    @#\n"
 ;
 	char str3[] =
 "#@                                                           @#\n"

x11vnc/remote.c

@@ -2537,6 +2537,14 @@ char *process_remote_cmd(char *cmd, int stringonly) {
 		sound_bell = 0;
 		goto done;
 	}
+	if (!strcmp(p, "sendbell")) {
+		NOTAPP
+		rfbLog("remote_cmd: sendbell.\n");
+		if (screen && client_count) {
+			rfbSendBell(screen);
+		}
+		goto done;
+	}
 	if (!strcmp(p, "sel")) {
 		if (query) {
 			snprintf(buf, bufn, "ans=%s:%d", p, watch_selection);

x11vnc/screen.c

@@ -1004,6 +1004,48 @@ void vnc_reflect_got_cursorshape(rfbClient *cl, int xhot, int yhot, int width, i
 	set_cursor(cursor_x, cursor_y, get_which_cursor());
 }
 
+static void from_libvncclient_CopyRectangleFromRectangle(rfbClient* client, int src_x, int src_y, int w, int h, int dest_x, int dest_y) {
+  int i,j;
+
+#define COPY_RECT_FROM_RECT(BPP) \
+  { \
+    uint##BPP##_t* _buffer=((uint##BPP##_t*)client->frameBuffer)+(src_y-dest_y)*client->width+src_x-dest_x; \
+    if (dest_y < src_y) { \
+      for(j = dest_y*client->width; j < (dest_y+h)*client->width; j += client->width) { \
+        if (dest_x < src_x) { \
+          for(i = dest_x; i < dest_x+w; i++) { \
+            ((uint##BPP##_t*)client->frameBuffer)[j+i]=_buffer[j+i]; \
+          } \
+        } else { \
+          for(i = dest_x+w-1; i >= dest_x; i--) { \
+            ((uint##BPP##_t*)client->frameBuffer)[j+i]=_buffer[j+i]; \
+          } \
+        } \
+      } \
+    } else { \
+      for(j = (dest_y+h-1)*client->width; j >= dest_y*client->width; j-=client->width) { \
+        if (dest_x < src_x) { \
+          for(i = dest_x; i < dest_x+w; i++) { \
+            ((uint##BPP##_t*)client->frameBuffer)[j+i]=_buffer[j+i]; \
+          } \
+        } else { \
+          for(i = dest_x+w-1; i >= dest_x; i--) { \
+            ((uint##BPP##_t*)client->frameBuffer)[j+i]=_buffer[j+i]; \
+          } \
+        } \
+      } \
+    } \
+  }
+
+  switch(client->format.bitsPerPixel) {
+  case  8: COPY_RECT_FROM_RECT(8);  break;
+  case 16: COPY_RECT_FROM_RECT(16); break;
+  case 32: COPY_RECT_FROM_RECT(32); break;
+  default:
+    rfbClientLog("Unsupported bitsPerPixel: %d\n",client->format.bitsPerPixel);
+  }
+}
+
 void vnc_reflect_got_copyrect(rfbClient *cl, int src_x, int src_y, int w, int h, int dest_x, int dest_y) {
 	sraRegionPtr reg;
 	int dx, dy, rc = -1;
@@ -1021,13 +1063,15 @@ void vnc_reflect_got_copyrect(rfbClient *cl, int src_x, int src_y, int w, int h,
 	if (dx != last_dx || dy != last_dy) {
 		rc = fb_push_wait(0.05, FB_COPY|FB_MOD);
 	}
-	if (0) fprintf(stderr, "vnc_reflect_got_copyrect: %dx%d+%d+%d   %d %d  rc=%d\n", dest_x, dest_y, w, h, dx, dy, rc);
+	if (1) fprintf(stderr, "vnc_reflect_got_copyrect: %03dx%03d+%03d+%03d   %3d %3d  rc=%d\n", dest_x, dest_y, w, h, dx, dy, rc);
 	reg = sraRgnCreateRect(dest_x, dest_y, dest_x + w, dest_y + h);
 	do_copyregion(reg, dx, dy, 0);
 	sraRgnDestroy(reg);
 
 	last_dx = dx;
 	last_dy = dy;
+
+	from_libvncclient_CopyRectangleFromRectangle(cl, src_x, src_y, w, h, dest_x, dest_y);
 }
 
 rfbBool vnc_reflect_resize(rfbClient *cl)  {

x11vnc/selection.c

@@ -169,11 +169,38 @@ void selection_request(XEvent *ev, char *type) {
 	}
 
 	if (! trapped_xerror) {
-		int ret = XSendEvent(req_event->display, req_event->requestor, False, 0,
-		    (XEvent *)&notify_event);
+		int ret = -2, skip_it = 0, ms = 0;
+		double now = dnow();
+		static double last_check = 0.0;
+
+		if (now > last_check + 0.2) {
+			XFlush_wr(dpy);
+			if (!valid_window(req_event->requestor , NULL, 1)) {
+				sync_it = 1;
+				skip_it = 1;
+				if (debug_sel) {
+					rfbLog("selection_request: not a valid window: 0x%x\n",
+					    req_event->requestor);
+				}
+				ms = 10;
+			}
+			if (trapped_xerror) {
+				sync_it = 1;
+				skip_it = 1;
+			}
+			last_check = dnow();
+		}
+
+		if (!skip_it) {
+			ret = XSendEvent(req_event->display, req_event->requestor, False, 0,
+			    (XEvent *)&notify_event);
+		}
 		if (debug_sel) {
 			rfbLog("XSendEvent() -> %d\n", ret);
 		}
+		if (ms > 0) {
+			usleep(ms * 1000);
+		}
 	}
 	if (trapped_xerror) {
 		rfbLog("selection_request: ignored XError while sending "
@@ -182,7 +209,7 @@ void selection_request(XEvent *ev, char *type) {
 
 	XFlush_wr(dpy);
 	if (sync_it) {
-		usleep(5 * 1000);
+		usleep(10 * 1000);
 		XSync(dpy, False);
 	}
 

x11vnc/sslhelper.c

@@ -1248,18 +1248,23 @@ void ssl_helper_pid(pid_t pid, int sock) {
 #	define HPSIZE 256
 	static pid_t helpers[HPSIZE];
 	static int   sockets[HPSIZE], first = 1;
-	int i, empty, set, status, db = 0;
+	int i, empty, set, status;
+	static int db = 0;
 
 	if (first) {
 		for (i=0; i < HPSIZE; i++)  {
 			helpers[i] = 0;
 			sockets[i] = 0;
 		}
+		if (getenv("SSL_HELPER_PID_DB")) {
+			db = 1;
+		}
 		first = 0;
 	}
 
+
 	if (pid == 0) {
-		/* killall */
+		/* killall or waitall */
 		for (i=0; i < HPSIZE; i++) {
 			if (helpers[i] == 0) {
 				sockets[i] = -1;
@@ -1279,13 +1284,17 @@ void ssl_helper_pid(pid_t pid, int sock) {
 				}
 
 #if LIBVNCSERVER_HAVE_SYS_WAIT_H && LIBVNCSERVER_HAVE_WAITPID 
-if (db) fprintf(stderr, "waitpid(%d)\n", helpers[i]);
 				wret = waitpid(helpers[i], &status, WNOHANG); 
+
+if (db) fprintf(stderr, "waitpid(%d)\n", helpers[i]);
+if (db) fprintf(stderr, "  waitret1=%d\n", wret);
+
 				if (kret == 0 && wret != helpers[i]) {
 					int k;
 					for (k=0; k < 10; k++) {
 						usleep(100 * 1000);
 						wret = waitpid(helpers[i], &status, WNOHANG); 
+if (db) fprintf(stderr, "  waitret2=%d\n", wret);
 						if (wret == helpers[i]) {
 							break;
 						}
@@ -1310,10 +1319,12 @@ if (db) fprintf(stderr, "ssl_helper_pid(%d, %d)\n", pid, sock);
 	for (i=0; i < HPSIZE; i++) {
 		if (helpers[i] == pid) {
 			if (sock == -1) {
-
 #if LIBVNCSERVER_HAVE_SYS_WAIT_H && LIBVNCSERVER_HAVE_WAITPID 
+				pid_t wret;
+				wret = waitpid(helpers[i], &status, WNOHANG); 
+
 if (db) fprintf(stderr, "waitpid(%d) 2\n", helpers[i]);
-				waitpid(helpers[i], &status, WNOHANG); 
+if (db) fprintf(stderr, "  waitret1=%d\n", wret);
 #endif
 				helpers[i] = 0;
 			}
@@ -2456,6 +2467,7 @@ void accept_openssl(int mode, int presock) {
 				}
 				screen->port = origport;
 				rfbLog("SSL: guessing child https finished.\n");
+				ssl_helper_pid(0, -2);
 				if (mode == OPENSSL_INETD) {
 					clean_up_exit(1);
 				}
@@ -2490,8 +2502,11 @@ void accept_openssl(int mode, int presock) {
 				}
 				rfbLog("SSL: OPENSSL_INETD guessing "
 				    "child https finished.\n");
+				ssl_helper_pid(0, -2);
 				clean_up_exit(1);
 			}
+			/* this will actually only get earlier https */
+			ssl_helper_pid(0, -2);
 			return;
 		}
 		kill(pid, SIGTERM);
@@ -3522,6 +3537,8 @@ static void ssl_xfer(int csock, int s_in, int s_out, int is_https) {
 			} else {
 				tv_use = tv_vnc_later;
 			}
+			/* try to clean out some zombies if we can. */
+			ssl_helper_pid(0, -2);
 		}
 		if (ssl_timeout_secs > 0) {
 			tv_use = ssl_timeout_secs;
@@ -3742,7 +3759,16 @@ void check_openssl(void) {
 	static double last_check = 0.0;
 	double now;
 
-	if (! use_openssl || openssl_sock < 0) {
+	if (! use_openssl) {
+		return;
+	}
+
+	if (time(NULL) > last_waitall + 120) {
+		last_waitall = time(NULL);
+		ssl_helper_pid(0, -2);	/* waitall */
+	}
+
+	if (openssl_sock < 0) {
 		return;
 	}
 
@@ -3752,11 +3778,6 @@ void check_openssl(void) {
 	}
 	last_check = now;
 
-	if (time(NULL) > last_waitall + 150) {
-		last_waitall = time(NULL);
-		ssl_helper_pid(0, -2);	/* waitall */
-	}
-
 	FD_ZERO(&fds);
 	FD_SET(openssl_sock, &fds);
 
@@ -3809,6 +3830,7 @@ void check_https(void) {
 static void init_prng(void) {
 	int db = 0, bytes, ubytes, fd;
 	char file[MSZ], dtmp[100];
+	unsigned int sr;
 
 	RAND_file_name(file, MSZ);
 
@@ -3838,6 +3860,9 @@ static void init_prng(void) {
 		RAND_poll();
 	}
 	
+	RAND_bytes((unsigned char *)&sr, 4);
+	srand(sr);
+
 	if (bytes > 0) {
 		if (! quiet) {
 			rfbLog("initialized PRNG with %d random bytes.\n",

x11vnc/ssltools.h

@@ -798,6 +798,9 @@ char find_display[] =
 "	exit 1\n"
 "fi\n"
 "\n"
+"LC_ALL=C\n"
+"export LC_ALL\n"
+"\n"
 "# util to try to match a display with a Linux VT and print\n"
 "# disp,VT=... etc.  Otherwise just print out display.\n"
 "#\n"
@@ -980,19 +983,21 @@ char find_display[] =
 "list=\"$list \"`who 2>/dev/null | grep \"^${user}[ 	]\" | awk '{print $NF}' | grep '(:[0-9]' | sed -e 's/[()]//g'`\n"
 "host=`hostname 2>/dev/null | sed -e 's/\\..*$//'`\n"
 "\n"
+"got_local_dm_file=\"\"\n"
+"\n"
 "if [ \"X$X11VNC_FINDDISPLAY_SKIP_XAUTH\" = \"X\" ]; then\n"
 "	# do a normal xauth list:\n"
 "	list=\"$list \"`xauth list | awk '{print $1}' | grep /unix | grep \"^${host}\" | sed -e 's/^.*:/:/' | sort -n | uniq`\n"
 "\n"
-"	# check for gdm and kdm non-NFS cookies in /tmp:\n"
-"	for xa in /tmp/.gdm* /tmp/.Xauth*\n"
+"	# check for gdm and kdm non-NFS cookies in /tmp: (and now /var/run/gdm)\n"
+"	for xa in /tmp/.gdm* /tmp/.Xauth* /var/run/gdm/auth-for-*/database /var/run/gdm/auth-cookie-*-for-*\n"
 "	do\n"
 "		# try to be somewhat careful about the real owner of the file:\n"
 "		if id | sed -e 's/ gid.*$//' | grep -w root > /dev/null; then\n"
 "			break\n"
 "		fi\n"
 "		if [ -f $xa -a -r $xa ]; then\n"
-"			if ls -l \"$xa\" | sed -e 's,/tmp.*$,,' | grep -w \"$user\" > /dev/null; then\n"
+"			if ls -l \"$xa\" | sed -e 's,/tmp.*$,,' -e 's,/var.*$,,' | grep -w \"$user\" > /dev/null; then\n"
 "				# append these too:\n"
 "				if find \"$xa\" -user \"$user\" -perm 600 > /dev/null; then\n"
 "					:\n"
@@ -1000,7 +1005,12 @@ char find_display[] =
 "					continue\n"
 "				fi\n"
 "				# it passes the ownership tests, add it:\n"
-"				list=\"$list \"`xauth -f \"$xa\" list | awk '{print $1}' | grep /unix | grep \"^${host}\" | sed -e 's/^.*:/:/' | sort -n | uniq | sed -e \"s,\\$,\\,$xa,\"`\n"
+"				# since the directory is (evidently) local, \"localhost\" is good too. (but beware XAUTHLOCALHOSTNAME in libxcb)\n"
+"				sav0=\"$list \"\n"
+"				list=\"$list \"`xauth -f \"$xa\" list | awk '{print $1}' | grep /unix | egrep -i \"^${host}|^localhost\" | sed -e 's/^.*:/:/' | sort -n | uniq | sed -e \"s,\\$,\\,$xa,\"`\n"
+"				if [ \"X$sav0\" != \"X$list\" ]; then\n"
+"					got_local_dm_file=1\n"
+"				fi\n"
 "			fi\n"
 "		fi\n"
 "	done\n"
@@ -1073,10 +1083,6 @@ char find_display[] =
 "	if [ \"X$ok\" = \"X1\" ]; then\n"
 "		# ok, put it on the list\n"
 "		poss=\"$poss $p\"\n"
-"		if [ \"X$xa\" != \"X\" ]; then\n"
-"			# xauth file too, if applicable\n"
-"			poss=\"$poss,$xa\"\n"
-"		fi\n"
 "	fi\n"
 "done\n"
 "\n"
@@ -1148,12 +1154,24 @@ char find_display[] =
 "\n"
 "		# check xauth for it:\n"
 "		if [ \"X$xa\" != \"X\" ]; then\n"
-"			XAUTHORITY=\"$xa\" xdpyinfo -display \"$p\" >/dev/null 2>&1\n"
+"			myenv=\"XAUTHORITY=$xa\"\n"
 "		else\n"
-"			xdpyinfo -display \"$p\" >/dev/null 2>&1\n"
+"			myenv=\"FOO_BAR_=baz\"\n"
+"		fi\n"
+"		env \"$myenv\" xdpyinfo -display \"$p\" >/dev/null 2>&1\n"
+"		rc=$?\n"
+"		if [ $rc != 0 -a \"X$XAUTHLOCALHOSTNAME\" = \"X\" ]; then\n"
+"			# guard against libxcb/desktop silliness: \n"
+"			env \"$myenv\" XAUTHLOCALHOSTNAME=localhost xdpyinfo -display \"$p\" >/dev/null 2>&1\n"
+"			rc=$?\n"
+"			if [ $rc = 0 ]; then\n"
+"				# better export it for cmds below...\n"
+"				XAUTHLOCALHOSTNAME=localhost\n"
+"				export XAUTHLOCALHOSTNAME\n"
+"			fi\n"
 "		fi\n"
 "\n"
-"		if [ $? = 0 ]; then\n"
+"		if [ $rc = 0 ]; then\n"
 "			if [ \"X$FD_TAG\" != \"X\" ]; then\n"
 "				# look for x11vnc special FD_TAG property:\n"
 "				if [ \"X$xa\" = \"X\" ]; then\n"
@@ -1286,6 +1304,9 @@ char create_display[] =
 "COLUMNS=256\n"
 "export COLUMNS\n"
 "\n"
+"LC_ALL=C\n"
+"export LC_ALL\n"
+"\n"
 "findfree() {\n"
 "	try=20\n"
 "	sry=99\n"

x11vnc/unixpw.c

@@ -16,6 +16,7 @@ extern char *crypt(const char*, const char *);
 #include "connections.h"
 #include "user.h"
 #include "connections.h"
+#include "sslhelper.h"
 #include "cursor.h"
 #include <rfb/default8x16.h>
 
@@ -1518,6 +1519,8 @@ static void apply_opts (char *user) {
 void unixpw_accept(char *user) {
 	apply_opts(user);
 
+	ssl_helper_pid(0, -2);	/* waitall */
+
 	if (accept_cmd && strstr(accept_cmd, "popup") == accept_cmd) {
 		if (use_dpy && strstr(use_dpy, "WAIT:") == use_dpy &&
 		    dpy == NULL) {

x11vnc/user.c

@@ -13,6 +13,7 @@
 #include "keyboard.h"
 #include "cursor.h"
 #include "remote.h"
+#include "sslhelper.h"
 #include "avahi.h"
 
 void check_switched_user(void);
@@ -590,6 +591,7 @@ static int guess_user_and_switch(char *str, int fb_mode) {
 			free(t);
 			continue;
 		}
+
 		if (switch_user(user, fb_mode)) {
 			rfbLog("switched to guessed user: %s\n", user);
 			free(t);
@@ -684,6 +686,8 @@ int switch_user(char *user, int fb_mode) {
 		user++;
 	}
 
+	ssl_helper_pid(0, -2);	/* waitall */
+
 	if (strstr(user, "guess=") == user) {
 		return guess_user_and_switch(user, fb_mode);
 	}
@@ -1370,10 +1374,27 @@ static void setup_fake_fb(XImage* fb_image, int w, int h, int b) {
 	fb_image->bits_per_pixel = b;
 	fb_image->bytes_per_line = w*b/8;
 	fb_image->bitmap_unit = -1;
-	fb_image->depth = 24;
-	fb_image->red_mask   = 0xff0000;
-	fb_image->green_mask = 0x00ff00;
-	fb_image->blue_mask  = 0x0000ff;
+	if (b >= 24) {
+		fb_image->depth = 24;
+		fb_image->red_mask   = 0xff0000;
+		fb_image->green_mask = 0x00ff00;
+		fb_image->blue_mask  = 0x0000ff;
+	} else if (b >= 16) {
+		fb_image->depth = 16;
+		fb_image->red_mask   = 0x003f;
+		fb_image->green_mask = 0x07c0;
+		fb_image->blue_mask  = 0xf800;
+	} else if (b >= 2) {
+		fb_image->depth = 8;
+		fb_image->red_mask   = 0x07;
+		fb_image->green_mask = 0x38;
+		fb_image->blue_mask  = 0xc0;
+	} else {
+		fb_image->depth = 1;
+		fb_image->red_mask   = 0x1;
+		fb_image->green_mask = 0x1;
+		fb_image->blue_mask  = 0x1;
+	}
 
 	depth = fb_image->depth;
 
@@ -2574,7 +2595,7 @@ int wait_for_client(int *argc, char** argv, int http) {
 	/* ugh, here we go... */
 	XImage* fb_image;
 	int w = 640, h = 480, b = 32;
-	int w0, h0, i, chg_raw_fb = 0;
+	int w0 = -1, h0 = -1, i, chg_raw_fb = 0;
 	char *str, *q, *cmd = NULL;
 	int db = 0, dt = 0;
 	char *create_cmd = NULL;
@@ -2618,10 +2639,32 @@ int wait_for_client(int *argc, char** argv, int http) {
 			w = w0;
 			h = h0;
 			rfbLog("wait_for_client set: w=%d h=%d\n", w, h);
+		} else {
+			w0 = -1;
+			h0 = -1;
 		}
 		*q = ':';
 		str = q;
 	}
+	if ((w0 == -1 || h0 == -1) && pad_geometry != NULL) {
+		int b0, del = 0;
+		char *s = pad_geometry;
+		if (strstr(s, "once:") == s) {
+			del = 1;
+			s += strlen("once:");
+		}
+		if (sscanf(s, "%dx%dx%d", &w0, &h0, &b0) == 3)  {
+			w = nabs(w0);
+			h = nabs(h0);
+			b = nabs(b0);
+		} else if (sscanf(s, "%dx%d", &w0, &h0) == 2)  {
+			w = nabs(w0);
+			h = nabs(h0);
+		}
+		if (del) {
+			pad_geometry = NULL;
+		}
+	}
 
 	/* str currently begins with a ':' */
 	if (strstr(str, ":cmd=") == str) {

x11vnc/userinput.c

@@ -9015,7 +9015,7 @@ if (ncdb && c) fprintf(stderr, "check_ncache purged %d events\n", c);
 			    "If there are painting errors press 3 Alt_L's (Left \"Alt\" key) in a row to repaint the screen.",
 			    white_pixel());
 			rfbDrawString(screen, &default8x16Font, dx, ds + Dy+6*dy,
-			    "More info:  http://www.karlrunge.com/x11vnc/#faq-client-caching",
+			    "More info:  http://www.karlrunge.com/x11vnc/faq.html#faq-client-caching",
 			    white_pixel());
 
 			ds += 11 * dy;

x11vnc/x11vnc.1

 .\" This file was automatically generated from x11vnc -help output.
-.TH X11VNC "1" "January 2009" "x11vnc " "User Commands"
+.TH X11VNC "1" "February 2009" "x11vnc " "User Commands"
 .SH NAME
 x11vnc - allow VNC connections to real X11 displays
-         version: 0.9.7, lastmod: 2009-01-11
+         version: 0.9.7, lastmod: 2009-01-24
 .SH SYNOPSIS
 .B x11vnc
 [OPTION]...
@@ -40,7 +40,7 @@ ssh \fB-t\fR \fB-L\fR 5900:localhost:5900 far-host 'x11vnc \fB-localhost\fR \fB-
 Also, use of a VNC password (-rfbauth or \fB-passwdfile)\fR is strongly recommended.
 .PP
 For additional info see: http://www.karlrunge.com/x11vnc/
-and  http://www.karlrunge.com/x11vnc/#faq
+and  http://www.karlrunge.com/x11vnc/faq.html
 .PP
 Config file support: if the file $HOME/.x11vncrc exists then each line in
 it is treated as a single command line option.  Disable with \fB-norc.\fR  For
@@ -1548,10 +1548,11 @@ is prescribed.
 The VNC Viewer-side needs to support SSL/TLS as well.
 See this URL and also the discussion below for
 ideas on how to enable SSL support for the viewer:
-http://www.karlrunge.com/x11vnc/#faq-ssl-tunnel-viewers
-x11vnc provides an SSL enabled Java viewer applet in
-the classes/ssl directory (-http or \fB-httpdir\fR options.)
-The SSVNC viewer package supports SSL tunnels too.
+http://www.karlrunge.com/x11vnc/faq.html#faq-ssl-tun
+nel-viewers x11vnc provides an SSL enabled Java
+viewer applet in the classes/ssl directory (-http or
+\fB-httpdir\fR options.)  The SSVNC viewer package supports
+SSL tunnels too.
 .IP
 If the VNC Viewer supports VeNCrypt or ANONTLS (vino's
 encryption mode) they are also supported by the \fB-ssl\fR
@@ -2786,6 +2787,10 @@ that do not support NewFBSize and one wants to make
 sure the initial viewer geometry will be big enough
 to handle all subsequent resizes (e.g. under \fB-xrandr,\fR
 \fB-remote\fR id:windowid, rescaling, etc.)
+.IP
+In \fB-unixpw\fR mode this sets the size of the login screen.
+Use "once:WxH" it ignore padgeom after the login
+screen is set up.
 .PP
 \fB-o\fR \fIlogfile\fR
 .IP
@@ -5164,6 +5169,8 @@ bell            enable  bell (if supported).
 .IP
 nobell          disable bell.
 .IP
+sendbell        ring the bell now.
+.IP
 nosel           enable  \fB-nosel\fR mode.
 .IP
 sel             disable \fB-nosel\fR mode.

x11vnc/x11vnc.c

@@ -1809,7 +1809,7 @@ char msg[] =
 "    2) You can actually see the cached pixel data if you scroll down\n"
 "       to it in your viewer; adjust your viewer's size to hide it.\n"
 "\n"
-"More info: http://www.karlrunge.com/x11vnc/#faq-client-caching\n"
+"More info: http://www.karlrunge.com/x11vnc/faq.html#faq-client-caching\n"
 "\n"
 "waiting for connections:\n"
 ;
@@ -1824,7 +1824,7 @@ char msg2[] =
 "\n"
 "    x11vnc -ncache 10 ...\n"
 "\n"
-"more info: http://www.karlrunge.com/x11vnc/#faq-client-caching\n"
+"more info: http://www.karlrunge.com/x11vnc/faq.html#faq-client-caching\n"
 "\n"
 ;
 
@@ -3775,6 +3775,11 @@ int main(int argc, char* argv[]) {
 		}
 	}
 
+	if (! getenv("NO_LIBXCB_ALLOW_SLOPPY_LOCK")) {
+		/* libxcb is a bit too strict for us sometimes... */
+		set_env("LIBXCB_ALLOW_SLOPPY_LOCK", "1");
+	}
+
 	/* set OS struct UT */
 	uname(&UT);
 
@@ -4167,6 +4172,14 @@ int main(int argc, char* argv[]) {
 		rfbLog("-passwd must be supplied when using -viewpasswd\n");
 		exit(1);
 	}
+	if (1) {
+		/* mix things up a little bit */
+		unsigned char buf[CHALLENGESIZE];
+		int k, kmax = (int) (500 * rfac()) + 100;
+		for (k=0; k < kmax; k++) {
+			rfbRandomBytes(buf);
+		}
+	}
 
 	if (SHOW_NO_PASSWORD_WARNING) {
 		char message[] = "-rfbauth, -passwdfile, -passwd password, "
@@ -4943,7 +4956,7 @@ if (0) fprintf(stderr, "XA: %s\n", getenv("XAUTHORITY"));
 		rfbLog("  client sides.  This mode works with any VNC viewer.\n");
 		rfbLog("  However, in most you can actually see the cached pixel\n");
 		rfbLog("  data by scrolling down, so you need to re-adjust its size.\n");
-		rfbLog("  See http://www.karlrunge.com/x11vnc/#faq-client-caching.\n");
+		rfbLog("  See http://www.karlrunge.com/x11vnc/faq.html#faq-client-caching.\n");
 		rfbLog("  If this mode yields undesired behavior (poor response,\n");
 		rfbLog("  painting errors, etc) it may be disabled via: '-ncache 0'\n");
 		rfbLog("  You can press 3 Alt_L's (Left \"Alt\" key) in a row to \n");

x11vnc/x11vnc_defs.c

@@ -15,7 +15,7 @@ int xtrap_base_event_type = 0;
 int xdamage_base_event_type = 0;
 
 /*               date +'lastmod: %Y-%m-%d' */
-char lastmod[] = "0.9.7 lastmod: 2009-01-11";
+char lastmod[] = "0.9.7 lastmod: 2009-01-24";
 
 /* X display info */
 

x11vnc/xwrappers.c

@@ -1262,6 +1262,24 @@ Display *XOpenDisplay_wr(char *display_name) {
 	d = XOpenDisplay(display_name);
 	if (db) fprintf(stderr, "XOpenDisplay_wr: %s  %p\n", display_name, (void *)d);
 
+	if (d == NULL) {
+	    if (!getenv("NO_XAUTHLOCALHOSTNAME")) {
+		if (!getenv("XAUTHLOCALHOSTNAME")) {
+			rfbLog("XOpenDisplay(\"%s\") failed.\n",
+			    display_name ? display_name : "");
+			rfbLog("Trying again with XAUTHLOCALHOSTNAME=localhost ...\n");
+			set_env("XAUTHLOCALHOSTNAME", "localhost");
+			d = XOpenDisplay(display_name);
+			if (0) {
+				char *ptr = getenv("XAUTHLOCALHOSTNAME");
+				if (ptr) {
+					*(ptr-2) = '_';	/* yow */
+				}
+			}
+		}
+	    }
+	}
+
 	xauth_raw(0);
 
 	return d;