• Stefy Lanza (nextime / spora )'s avatar
    an unset text_len made llama.cpp read an empty prompt · d2150f97
    Stefy Lanza (nextime / spora ) authored
    Every image sent to a GGUF vision embedder answered 500. Caught on live traffic
    by the 5xx logging added hours earlier, which named it in one line:
    
        [radeon] mtmd_tokenize: error: number of media markers in text (0) does not
                 match number of bitmaps (1)
        [radeon] [http] 500 on POST /v1/embeddings:
                 'Embedding failed: mtmd_tokenize failed (2)'
    
    `mtmd_input_text` carries a `text_len` beside its `c_char_p`, and the struct was
    built with the constructor form, which leaves it at 0. Measured in the
    container: that form gives text_len == 0 for a 38-byte prompt, the field-by-field
    form gives 38. llama.cpp read a zero-length prompt, found no media marker in it,
    and refused the bitmap it had been handed. The marker was never the problem --
    mtmd_default_marker() is b'<__media__>' and _prompt() interpolates it, both
    verified against the running engine, and both were suspected first.
    
    Built field by field now, exactly as llama_cpp's own chat handler does it, which
    also keeps a NAMED reference to the encoded bytes. That second half matters on
    its own: `text` is a c_char_p, so a temporary is free to be collected while the
    struct still points at it -- a latent defect in the same two lines that would
    have been intermittent rather than total.
    
    Verified against the running server afterwards: image-only, text-only and
    text+image to gme-Qwen2-VL-2B-Instruct-Q4_K_M all return 1536-d embeddings.
    Each of the two image cases was a 500 before.
    
    The request log now reports the image count. Its absence is why the search
    started in the wrong place: `model=gme-… inputs=4 chars=84` reads as a text-only
    request, because _summarise logged `input` and never `image`, so a failure on
    the IMAGE path looked impossible. Counts only, no content, like the rest of
    that line.
    Co-Authored-By: 's avatarClaude Opus 5 <noreply@anthropic.com>
    Claude-Session: https://claude.ai/code/session_014T3rZozi1Ehk96NG1WesgC
    d2150f97
Name
Last commit
Last update
..
__init__.py Loading commit data...
_film_net.py Loading commit data...
_rife_ifnet.py Loading commit data...
acestep_worker.py Loading commit data...
app.py Loading commit data...
archive.py Loading commit data...
audio_backends.py Loading commit data...
audio_clean.py Loading commit data...
audio_gen.py Loading commit data...
audio_stems.py Loading commit data...
audiocraft_worker.py Loading commit data...
canary_worker.py Loading commit data...
characters.py Loading commit data...
chunking.py Loading commit data...
colibri_worker.py Loading commit data...
compose.py Loading commit data...
context_overflow.py Loading commit data...
crisperwhisper_worker.py Loading commit data...
custom_pipelines.py Loading commit data...
diarization.py Loading commit data...
ds4_kv_janitor.py Loading commit data...
ds4_worker.py Loading commit data...
embeddings.py Loading commit data...
environments.py Loading commit data...
faceswap.py Loading commit data...
fastlog.py Loading commit data...
h3_worker.py Loading commit data...
host_worker.py Loading commit data...
hub_compat.py Loading commit data...
images.py Loading commit data...
k3_worker.py Loading commit data...
kt_worker.py Loading commit data...
lang_codes.py Loading commit data...
lipsync.py Loading commit data...
lipsync_engines.py Loading commit data...
log.py Loading commit data...
longcat_worker.py Loading commit data...
loop_watch.py Loading commit data...
lora_archs.py Loading commit data...
loras.py Loading commit data...
melotts_worker.py Loading commit data...
model_test.py Loading commit data...
models_transfer.py Loading commit data...
moderation.py Loading commit data...
mux_remote.py Loading commit data...
ocr.py Loading commit data...
parler_worker.py Loading commit data...
pipelines.py Loading commit data...
pod_http.py Loading commit data...
pod_telemetry.py Loading commit data...
pod_tls.py Loading commit data...
podlog.py Loading commit data...
prompt_cache.py Loading commit data...
pyannote_worker.py Loading commit data...
ratelimit.py Loading commit data...
remote_gateway.py Loading commit data...
request_progress.py Loading commit data...
rerank.py Loading commit data...
runpod_client.py Loading commit data...
runpod_fleet_share.py Loading commit data...
runpod_ledger.py Loading commit data...
runpod_worker.py Loading commit data...
serving_load.py Loading commit data...
spatial.py Loading commit data...
speaker_embeddings.py Loading commit data...
speaker_registry.py Loading commit data...
state.py Loading commit data...
stt_backends.py Loading commit data...
text.py Loading commit data...
thread_pool.py Loading commit data...
transcriptions.py Loading commit data...
tts.py Loading commit data...
tts_backends.py Loading commit data...
uploads.py Loading commit data...
urlutils.py Loading commit data...
venv_env.py Loading commit data...
video.py Loading commit data...
vllm_worker.py Loading commit data...
voice_clone.py Loading commit data...
voice_convert.py Loading commit data...
vpr_salad_server.py Loading commit data...
xtts_worker.py Loading commit data...