• Stefy Lanza (nextime / spora )'s avatar
    and the reading side turned "0" into True (v0.4.41) · f099a1e0
    Stefy Lanza (nextime / spora ) authored
    v0.4.40 fixed the WRITER: a boolean sent through the pod env builder's
    int loop was dropped, because `False == 0`. The reader had the same bug
    in mirror image. The env row was declared with `bool` as its cast:
    
        ("CODERAI_OCR_EARLY_LOOP_ABORT", "early_loop_abort", bool)
    
    and the typed loop does `_cast(_val)` -- so `bool("0")` is True, and a
    pod sent `CODERAI_OCR_EARLY_LOOP_ABORT=0` turned the feature ON.
    
    One flag, two opposite coercions, both wrong in the same direction: it
    could only ever be enabled. Caught by the A/B test it was blocking --
    the "abort off" run reported 8 aborts.
    
    Booleans belong in the `_flag()` loop, which reads the STRING ("1",
    "true", "yes", "on" and nothing else), because that is the only way an
    environment variable can express false. Moved there, with a guard that
    no CODERAI_* env row anywhere casts with `bool`.
    Co-Authored-By: 's avatarClaude Opus 5 <noreply@anthropic.com>
    Claude-Session: https://claude.ai/code/session_01KnfkxBpcZ1v6ypRFFyhrVM
    f099a1e0
test_pod_env_booleans.py 4.82 KB