cleanup old TODO items

fixed minor issues


git-svn-id: https://pycam.svn.sourceforge.net/svnroot/pycam/trunk@907 bbaffbd6-741e-11dd-a85d-61de82d9cad9

pycam

@@ -267,7 +267,6 @@ def execute(parser, opts, args, pycam):
                 "surface": ("DropCutter", "PathAccumulator"),
                 "engrave": ("EngraveCutter", "SimpleCutter"),
             }[opts.process_path_strategy]
-        # TODO: add the miling_style option
         tps.set_process_settings(path_generator, postprocessor,
                 opts.process_path_direction,
                 material_allowance=opts.process_material_allowance,
@@ -372,7 +371,6 @@ def execute(parser, opts, args, pycam):
                 handler, closer = get_output_handler(opts.export_gcode)
                 if handler is None:
                     return EXIT_CODES["write_output_failed"]
-                # TODO: change to the new gcode exporter
                 generator = pycam.Exporters.GCodeExporter.GCodeGenerator(
                         handler, metric_units = (opts.unit_size == "mm"),
                         safety_height=opts.safety_height,

src/pycam/Geometry/Polygon.py

@@ -79,6 +79,8 @@ class Polygon(TransformableContainer):
                     self._update_limits(line.p2)
                 else:
                     self.is_closed = True
+                # take care that the line_cache is flushed
+                self.reset_cache()
             else:
                 # the new Line can be added to the beginning of the polygon
                 if (len(self._points) > 1) \
@@ -90,6 +92,8 @@ class Polygon(TransformableContainer):
                     self._update_limits(line.p1)
                 else:
                     self.is_closed = True
+                # take care that the line_cache is flushed
+                self.reset_cache()
 
     def __len__(self):
         return len(self._points)

src/pycam/Gui/Project.py

@@ -1734,8 +1734,7 @@ class ProjectGui:
                 if sorted_keys:
                     font_selector.set_active(0)
                 else:
-                    # TODO: show some warning - no fonts found
-                    pass
+                    log.warn("No single-line fonts found!")
                 font_selector.connect("changed",
                         self.update_font_dialog_preview)
                 font_selector.show()

src/pycam/Importers/STLImporter.py

@@ -145,7 +145,6 @@ def ImportModel(filename, use_kdtree=True, program_locations=None, unit=None,
                 t = Triangle(p1, p3, p2)
             elif dotcross < 0:
                 if not normal_conflict_warning_seen:
-                    # TODO: use the line number here instead of its content
                     log.warn(("Inconsistent normal/vertices found in facet " \
                             + "definition %d of '%s'. Please validate the STL " \
                             + "file!") % (i, filename))

src/pycam/Simulation/ODEBlocks.py

@@ -78,9 +78,7 @@ class ODEBlocks:
         # for now we may only move from low x/y values to higher x/y values
         if (location_start.x > location_end.x) \
                 or (location_start.y > location_end.y):
-            swap = location_start
-            location_start = location_end
-            location_end = swap
+            location_start, location_end = location_end, location_start
         cutter_body = ode.Body(self.world)
         cutter_shape, cutter_position_func = self.cutter.get_shape("ODE")
         self.space.add(cutter_shape)

src/pycam/Toolpath/SupportGrid.py

@@ -164,8 +164,6 @@ def get_support_distributed(model, z_plane, average_distance,
     if hasattr(model, "get_polygons"):
         polygons = model.get_polygons()
     else:
-        # TODO: Solid models are not supported, yet - we need to get the
-        # maximum outline of the model.
         polygons = model.get_waterline_polygons(Plane(Point(0, 0, z_plane),
                 Vector(0, 0, 1)))
     bridge_positions = []