• dscho's avatar
    The PseudoEncoding extension code was getting silly: · 951ec26b
    dscho authored
    If the client asked for an encoding, and no enabled extension handled it,
    LibVNCServer would walk through all extensions, and if they promised to handle
    the encoding, execute the extension's newClient() if it was not NULL.
    
    However, if newClient is not NULL, it will be called when a client connects,
    and if it returns TRUE, the extension will be enabled. Since all the state of
    the extension should be in the client data, there is no good reason why
    newClient should return FALSE the first time (thus not enabling the extension),
    but TRUE when called just before calling enablePseudoEncoding().
    
    So in effect, the extension got enabled all the time, even if that was not
    necessary.
    
    The resolution is to pass a void** to enablePseudoEncoding. This has the
    further advantage that enablePseudoEncoding can remalloc() or free() the
    data without problems. Though keep in mind that if enablePseudoEncoding()
    is called on a not-yet-enabled extension, the passed data points to NULL.
    951ec26b
rfb.h 29.6 KB